Expertise Penalty wrong check

[Horyon]

Хроники

1. Shadow of the Kamael

Исходники

Присутствуют

Сборка

L2jMobius Master class ch2

Hi again guys.

I try to re-install the expertise, and everything is going fine until, the grade check everything that i equip as a high grade.



Lv. 85 character with R grade expertise, getting penalty from D ring.

So far i understand this is the check is here. Player.java

public void refreshExpertisePenalty()
    {
 if (! Config.EXPERTISE_PENALTY)
        {
            return;
        }
       
        final CrystalType expertiseLevel = _expertiseLevel.plusLevel(_expertisePenaltyBonus);
        int armorPenalty = 0;
        int weaponPenalty = 0;
        for (Item item : _inventory.getPaperdollItems(item -> (item != null) && ((item.getItemType() != EtcItemType.ARROW) && (item.getItemType() != EtcItemType.BOLT)) && item.getTemplate().getCrystalType().isGreater(expertiseLevel)))
        {
            if (item.isArmor())
            {
  Armor penalty level increases depending on amount of penalty armors equipped, not grade level difference.
                armorPenalty = CommonUtil.constrain(armorPenalty + 1, 0, 4);
            }
            else
            {
  Weapon penalty level increases based on grade difference.
                weaponPenalty = CommonUtil.constrain(item.getTemplate().getCrystalType().getLevel() - expertiseLevel.getLevel(), 0, 4);
            }
        }
       
        boolean changed = false;
        if ((_expertiseWeaponPenalty != weaponPenalty) || (getSkillLevel(CommonSkill.WEAPON_GRADE_PENALTY.getId()) != weaponPenalty))
        {
            _expertiseWeaponPenalty = weaponPenalty;
            if (_expertiseWeaponPenalty > 0)
            {
                addSkill(SkillData.getInstance().getSkill(CommonSkill.WEAPON_GRADE_PENALTY.getId(), _expertiseWeaponPenalty));
            }
            else
            {
                removeSkill(CommonSkill.WEAPON_GRADE_PENALTY.getId(), true);
            }
            changed = true;
        }
       
        if ((_expertiseArmorPenalty != armorPenalty) || (getSkillLevel(CommonSkill.ARMOR_GRADE_PENALTY.getId()) != armorPenalty))
        {
            _expertiseArmorPenalty = armorPenalty;
            if (_expertiseArmorPenalty > 0)
            {
                addSkill(SkillData.getInstance().getSkill(CommonSkill.ARMOR_GRADE_PENALTY.getId(), _expertiseArmorPenalty));
            }
            else
            {
                removeSkill(CommonSkill.ARMOR_GRADE_PENALTY.getId(), true);
            }
            changed = true;
        }
       
        if (changed)
        {
 sendSkillList();  Update expertise penalty icon in skill list.
            sendPacket(new EtcStatusUpdate(this));
        }
    }

As always ty for help. =)

Hi again guys.

I try to re-install the expertise, and everything is going fine until, the grade check everything that i equip as a high grade.



Lv. 85 character with R grade expertise, getting penalty from D ring.

So far i understand this is the check is here. Player.java

public void refreshExpertisePenalty()
    {
 if (! Config.EXPERTISE_PENALTY)
        {
            return;
        }
      
        final CrystalType expertiseLevel = _expertiseLevel.plusLevel(_expertisePenaltyBonus);
        int armorPenalty = 0;
        int weaponPenalty = 0;
        for (Item item : _inventory.getPaperdollItems(item -> (item != null) && ((item.getItemType() != EtcItemType.ARROW) && (item.getItemType() != EtcItemType.BOLT)) && item.getTemplate().getCrystalType().isGreater(expertiseLevel)))
        {
            if (item.isArmor())
            {
  Armor penalty level increases depending on amount of penalty armors equipped, not grade level difference.
                armorPenalty = CommonUtil.constrain(armorPenalty + 1, 0, 4);
            }
            else
            {
  Weapon penalty level increases based on grade difference.
                weaponPenalty = CommonUtil.constrain(item.getTemplate().getCrystalType().getLevel() - expertiseLevel.getLevel(), 0, 4);
            }
        }
      
        boolean changed = false;
        if ((_expertiseWeaponPenalty != weaponPenalty) || (getSkillLevel(CommonSkill.WEAPON_GRADE_PENALTY.getId()) != weaponPenalty))
        {
            _expertiseWeaponPenalty = weaponPenalty;
            if (_expertiseWeaponPenalty > 0)
            {
                addSkill(SkillData.getInstance().getSkill(CommonSkill.WEAPON_GRADE_PENALTY.getId(), _expertiseWeaponPenalty));
            }
            else
            {
                removeSkill(CommonSkill.WEAPON_GRADE_PENALTY.getId(), true);
            }
            changed = true;
        }
      
        if ((_expertiseArmorPenalty != armorPenalty) || (getSkillLevel(CommonSkill.ARMOR_GRADE_PENALTY.getId()) != armorPenalty))
        {
            _expertiseArmorPenalty = armorPenalty;
            if (_expertiseArmorPenalty > 0)
            {
                addSkill(SkillData.getInstance().getSkill(CommonSkill.ARMOR_GRADE_PENALTY.getId(), _expertiseArmorPenalty));
            }
            else
            {
                removeSkill(CommonSkill.ARMOR_GRADE_PENALTY.getId(), true);
            }
            changed = true;
        }
      
        if (changed)
        {
 sendSkillList();  Update expertise penalty icon in skill list.
            sendPacket(new EtcStatusUpdate(this));
        }
    }

As always ty for help. =)

I believe the problem is the effect of Expertise... the skill are not giving the ability to use the grade.

Really need help on it... Bump <3

 

[Beliano]

Look in skill 4267 how much lvl is there

 

[Horyon]

Look in skill 4267 how much lvl is there

Just 1

 

[Salty Mike]

Посмотреть вложение 47884
Just 1

First of all, there should be two other Grade Penalty skills. The one you are using is not even complete. It has no effects. Search for Weapon Grade Penalty and Armor Grade Penalty skills.

These two at the bottom here:


Anyway, here is what I find peculiar:

- your "armorPenalty" stays 0+1 (or 1) always!

            if (item.isArmor())
            {
                // Armor penalty level increases depending on amount of penalty armors equipped, not grade level difference.
                armorPenalty = CommonUtil.constrain(armorPenalty + 1, 0, 4);
            }

secondly, in one place you compare expertise level with getCrystalType().getLevel, while the if compares the getCrystalType() without its level - item.getTemplate().getCrystalType().isGreater(expertiseLevel)

 

[Horyon]

First of all, there should be two other Grade Penalty skills. The one you are using is not even complete. It has no effects. Search for Weapon Grade Penalty and Armor Grade Penalty skills.

These two at the bottom here:

Посмотреть вложение 47885
Anyway, here is what I find peculiar:

- your "armorPenalty" stays 0+1 (or 1) always!

            if (item.isArmor())
            {
                // Armor penalty level increases depending on amount of penalty armors equipped, not grade level difference.
                armorPenalty = CommonUtil.constrain(armorPenalty + 1, 0, 4);
            }

secondly, in one place you compare expertise level with getCrystalType().getLevel, while the if compares the getCrystalType() without its level - item.getTemplate().getCrystalType().isGreater(expertiseLevel)

I'll investigate @Salty Mike,

ty